Getting "Installation failed" on updates, even on success

[mherger]

Hi,

I'm working on an add-on which is returning a generic "Failed to install addon" (ADDON_INST_FAIL) error message when I install it on top of an existing installation (update). At the same time I'm mailed an "Addon Installation suceeded" mail. And it does indeed work as expected.

What is causing this spurious failure message? I tried to figure out the code which is triggering it. But I couldn't figure out what is calling that JS method. Is this something in remove.sh which might be causing it? But why would I then get the success message mailed?

Michael

[mherger]

Oh, fwiw: I'm seeing this on firmwares 4.1.8 (NV+) up to the latest 5.3.3 (Duo v2)

[mdgm]

Do you have a link to your add-on?

[mherger]

Yes, it's all in our public repository:

http://svn.slimdevices.com/slim/7.7/trunk/platforms/readynas/addon_template/

[mdgm]

What ReadyNAS platform is that for. Is that the Sparc one?

So you see the same error on Sparc, x86 and ARM?

[mherger]

What ReadyNAS platform is that for. Is that the Sparc one?
So you see the same error on Sparc, x86 and ARM?

We're using the same script for all three platforms. And yes, we're seeing that message on all of them.

What's odd is that we used to have an older package which was originally created for the good ol' sparc models. With that old package we would only get the error on 4.2+, but not on the sparc's 4.1.8. With the new package it's the same on all of them.

[mdgm]

Ah, I found the compiled add-on here: http://downloads.slimdevices.com/nightly/?ver=7.7

[mdgm]

When I run install.sh via the command line, I get an error:

Code: Select all

sh install.sh
grep: /c/.squeezeboxserver/prefs/server.prefs: No such file or directory
Making sure Logitech Media Server is stopped already: No squeezeboxserve found running; none killed.
Starting Logitech Media Server: .


I'll try running it again to simulate an upgrade.

Edit: no problems with update via command line.

[mherger]

Thanks for the hint - yeah, will check for the file's existence.

How would I unpack an addon so I could run the script manually? It's not a simple tarball, is it?

[WhoCares?]

Most likely cause is that you're restarting Apache either in install.sh or remove.sh (the latter being the most likely cause). This will interrupt the installation process which itself is a subprocess of Apache in such a way that it will emit the "Installation failed" message. To fix this, do NOT restart Apache using either the "kill ..." or the "-k restart" method. Instead use "-k graceful" which will only restart those Apache processes that aren't occupied with a task immediately. Thus, the install subprocess will finish normally first and once that it is done it will also restart.

-Stefan

BTW: This problem currently should be specific o the ARM platform so I'm wondering why you're seeing it on Sparc and x86 as well.

[WhoCares?]

And lest I forget: Another cause may be (depending on the firmware version) that the script produces an error somewhen during it's run (or in case of ARM: produces some sort of output to STDOUT). This also will trigger the "Installation failed" message.

-Stefan

[mherger]

And lest I forget: Another cause may be (depending on the firmware version) that the script produces an error somewhen during it's run (or in case of ARM: produces some sort of output to STDOUT). This also will trigger the "Installation failed" message.

Oh, this is very likely to happen... I'll review my script and add a few redirects to /dev/null. Thanks for that hint!

[mdgm]

The remove script does restart apache using "killall -USR1 apache-ssl". So as suggested replace this with

Code: Select all

apache-ssl -f /etc/frontview/apache/httpd.conf -k graceful


[WhoCares?]

How would I unpack an addon so I could run the script manually? It's not a simple tarball, is it?

Code: Select all

#!/bin/bash
ARCH=`uname -m`
if [ "${ARCH}" == "padre" ]; then
  BSIZE=512
else
  BSIZE=16384
fi

if [ -f $1 ]; then
  TFIL=`basename $1 .bin`
  TFIL="${TFIL}.tar"
  dd if=$1 of=${TFIL} bs=${BSIZE} skip=1
else
  echo "Add-on file doesn't exist"
fi

From the top of my head so there may be syntax errors in there

-Stefan

[WhoCares?]

The remove script does restart apache using "killall -USR1 apache-ssl". So as suggested replace this with

Code: Select all

apache-ssl -f /etc/frontview/apache/httpd.conf -k graceful


I prefer to use this:

Code: Select all

/usr/sbin/apache-ssl -f /etc/frontview/apache/httpd.conf -t && /usr/sbin/apache-ssl -f /etc/frontview/apache/httpd.conf -k graceful


This makes sure that apache only gets restarted if it has a valid config. Prevents killing off Frontview ..

-Stefan